[Mesa-dev] [PATCH] mesa: Expose GL_OES_texture_npot on GLES1

Chad Versace chad.versace at linux.intel.com
Wed May 8 10:33:25 PDT 2013


On 05/08/2013 10:05 AM, Kenneth Graunke wrote:
> On 05/08/2013 09:48 AM, Chad Versace wrote:
>> Mesa's extension table incorrectly lists this GL_OES_texture_npot as
>> ES2-only. It's also an ES1 extension. This patch adds ES1 to the
>> extensions API mask.
>>
>>  From the GL_OES_texture_npot spec:
>>      OpenGL ES 1.0 or OpenGL ES 2.0 is required. This extension is
>>      written against OpenGL ES 1.1.12 and OpenGL ES 2.0.25.
>>
>> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
>> ---
>>   src/mesa/main/extensions.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
>> index 8b67fca..8eb45ff 100644
>> --- a/src/mesa/main/extensions.c
>> +++ b/src/mesa/main/extensions.c
>> @@ -279,7 +279,7 @@ static const struct extension extension_table[] = {
>>      { "GL_OES_texture_cube_map",                    o(ARB_texture_cube_map),                         ES1,       2007 },
>>      { "GL_OES_texture_env_crossbar",                o(ARB_texture_env_crossbar),                     ES1,       2005 },
>>      { "GL_OES_texture_mirrored_repeat",             o(dummy_true),                                   ES1,       2005 },
>> -   { "GL_OES_texture_npot",                        o(ARB_texture_non_power_of_two),                       ES2, 2005 },
>> +   { "GL_OES_texture_npot",                        o(ARB_texture_non_power_of_two),                 ES1,  ES2, 2005 },
>>      { "GL_OES_vertex_array_object",                 o(dummy_true),                                   ES1 | ES2, 2010 },
>>
>>      /* Vendor extensions */
>
> This even compiles?
>
> With the change to ES1 | ES2, this would be:
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Yes, surprisingly it compiles.

Thanks for catching the mistake.


More information about the mesa-dev mailing list