[Mesa-dev] [PATCH] intel: Don't spam "intelReadPixels: fallback to swrast" all the time.

Kenneth Graunke kenneth at whitecape.org
Wed May 15 10:03:08 PDT 2013


Unless the application is using PBOs, any call to glReadPixels will hit
this message.  Hitting this does mean mapping the buffer and accessing
it via the CPU, but that isn't necessarily the worst thing in the world.

apitrace's image dumping code hits this path, causing it to spam
hundreds of thousands of performance warnings via ARB_debug_output,
which makes it difficult to see actual errors.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/intel/intel_pixel_read.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_pixel_read.c b/src/mesa/drivers/dri/intel/intel_pixel_read.c
index 6b715d0..dd482af 100644
--- a/src/mesa/drivers/dri/intel/intel_pixel_read.c
+++ b/src/mesa/drivers/dri/intel/intel_pixel_read.c
@@ -188,8 +188,6 @@ intelReadPixels(struct gl_context * ctx,
    intel_prepare_render(intel);
    intel->front_buffer_dirty = dirty;
 
-   perf_debug("%s: fallback to swrast\n", __FUNCTION__);
-
    /* Update Mesa state before calling _mesa_readpixels().
     * XXX this may not be needed since ReadPixels no longer uses the
     * span code.
-- 
1.8.2.3



More information about the mesa-dev mailing list