[Mesa-dev] [PATCH 1/2] i965: Add cases for ir_binop_vector_extract that assert.

Eric Anholt eric at anholt.net
Fri May 17 12:45:22 PDT 2013


Eric Anholt <eric at anholt.net> writes:

> Kenneth Graunke <kenneth at whitecape.org> writes:
>
>> do_vec_index_to_swizzle() should remove any vector extract operations
>> with a constant index.  It's unconditionally called from
>> do_common_optimization().
>>
>> do_vec_index_to_cond_assign() should remove the rest, and it is
>> unconditionally called from brw_link_shader().  This means that we
>> should never see ir_binop_vector_extract in the backend.
>>
>> Silences compiler warnings.
>
> I found warnings also in brw_fs_visitor.cpp for the same, plus
> vector_insert, and was about to send that patch out.  I'm confused how
> you aren't seeing those.

Err, didn't see patch 2.  Still, brw_fs_visitor.cpp.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130517/b2d79876/attachment.pgp>


More information about the mesa-dev mailing list