[Mesa-dev] [RFC PATCH] ARB_vp/ARB_fp: accept duplicate precision options

[Eric Anholt]

Chris Forbes <chrisf at ijw.co.nz> writes:

> Relaxes the validation of
>
>    OPTION ARB_precision_hint_{nicest,fastest};
>
> to allow duplicate options. The spec says that both /nicest/ and
> /fastest/ cannot be specified together, but could be interpreted
> either way for respecification of the same option.
>
> Other drivers (NVIDIA etc) accept this, and at least one Unity3D game
> expects it to succeed (Kerbal Space Program).

I think this change is well supported by the spec:

    Only one precision control option may be specified by any given 
    fragment program.  A fragment program that specifies both the
    "ARB_precision_hint_fastest" and "ARB_precision_hint_nicest" program
    options will fail to load.

with the second sentence clarifying what exactly is meant in the first.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130521/1df57ec3/attachment.pgp>