[Mesa-dev] [PATCH v4 15/17] glsl linker: support arrays of interface block instances

Kenneth Graunke kenneth at whitecape.org
Wed May 22 11:13:50 PDT 2013


On 05/16/2013 05:44 PM, Jordan Justen wrote:
> With this change we now support interface block arrays.
> For example, cases like this:
>
> out block_name {
>      float f;
> } block_instance[2];
>
> This allows Mesa to pass the piglit glsl-1.50 test:
> * execution/interface-blocks-complex-vs-fs.shader_test
>
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>

This looks like it'll probably work and at this point I really want your 
code to land.  I'm not 100% confident in this, but I haven't found any 
concrete concerns and we can always fix things up later if we find any 
issues.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>



More information about the mesa-dev mailing list