[Mesa-dev] [PATCH 01/12] intel: Conditionally compile mcs-related code for i965 only.

Chad Versace chad.versace at linux.intel.com
Thu May 23 12:02:41 PDT 2013


On 05/23/2013 09:33 AM, Paul Berry wrote:
> On 22 May 2013 12:18, Ian Romanick <idr at freedesktop.org> wrote:
>
>> On 05/21/2013 04:52 PM, Paul Berry wrote:
>>
>>> This patch ifdefs out intel_mipmap_tree::mcs_mt when building the i915
>>> (pre-Gen4) driver (MCS buffers aren't supported until Gen7, so there
>>> is no need for this field in the i915 driver).  This should make it a
>>> bit easier to implement fast color clears without undue risk to i915.
>>>
>>
>> We have a bunch of other fields like this (e.g., hiz_mt).  Should we have
>> done this with those fields, or is this case different?
>
>
> Probably the only difference in this case is who is writing the patches :)
>
> I'd be willing to write a follow-up patch that ifdefs out some of the other
> i965-specific fields if there's interest.

For the record, I'm not opposed to any patches that #ifdef out hiz_mt.



More information about the mesa-dev mailing list