[Mesa-dev] [PATCH 3/4] util/blitter: make sure the blitter can restore all viewports

Zack Rusin zackr at vmware.com
Thu May 23 15:05:49 PDT 2013


> Same as the the first patch: u_blitter doesn't really need to change
> more than one scissor and viewport. With the start_slot parameter in
> set_viewport_states and set_scissor_states, you can just save, set,
> and restore the first slot. Note that the same approach is also used
> for the vertex buffer (only the first slot is changed by u_blitter).

Sure, but the count on restoring is going to be incorrect. A lot of code depends on the knowledge of how many viewports/scissors are set and unless the restoring can properly restore the count, all of it will be broken.

z


More information about the mesa-dev mailing list