[Mesa-dev] [PATCH] mesa: fix error checking of DXT sRGB formats in _mesa_base_tex_format()

Eric Anholt eric at anholt.net
Thu May 30 08:56:22 PDT 2013


Brian Paul <brianp at vmware.com> writes:

> For formats such as GL_COMPRESSED_SRGB_S3TC_DXT1_EXT we need to
> have both the GL_EXT_texture_sRGB and GL_EXT_texture_compression_s3tc
> extensions.  This patch adds the missing check for the later.
>
> Found when checking out https://bugs.freedesktop.org/show_bug.cgi?id=65173

Ah, this patch was a bit confusing without the context of "if
(ctx->Extensions.EXT_texture_sRGB) {" wrapping the switch statement.

Reviewed-by: Eric Anholt <eric at anholt.net>

On a similar note, looks like we're allowing a lot of extension-provided
L/LA/A/I formats on core.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130530/6de124f6/attachment.pgp>


More information about the mesa-dev mailing list