[Mesa-dev] [PATCH 1/2] dri: Add driconf option clamp_max_samples

[Paul Berry]

On 31 October 2013 18:36, Chad Versace <chad.versace at linux.intel.com> wrote:

> This clamps GL_MAX_SAMPLES to the given value. If negative, then no
> clamping occurs.
>
> This patch adds the option, but no driver respects it yet.
>

Do you plan to implement support for this option in all drivers or just
i965?  If you're just implementing it for i965, maybe it should go in
src/mesa/drivers/dri/i965/intel_screen.c.

Other than that, the patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


>
> CC: Eric Anholt <eric at anholt.org>
> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
> ---
>
> This little series lives on my driconf-clamp-max-samples branch.
>
>
>  src/mesa/drivers/dri/common/xmlpool/t_options.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/common/xmlpool/t_options.h
> b/src/mesa/drivers/dri/common/xmlpool/t_options.h
> index 3bf804a..2a02406 100644
> --- a/src/mesa/drivers/dri/common/xmlpool/t_options.h
> +++ b/src/mesa/drivers/dri/common/xmlpool/t_options.h
> @@ -215,7 +215,10 @@ DRI_CONF_OPT_BEGIN_V(pp_jimenezmlaa_color,int,def, #
> min ":" # max ) \
>          DRI_CONF_DESC(en,gettext("Morphological anti-aliasing based on
> Jimenez\\\' MLAA. 0 to disable, 8 for default quality. Color version,
> usable with 2d GL apps")) \
>  DRI_CONF_OPT_END
>
> -
> +#define DRI_CONF_CLAMP_MAX_SAMPLES() \
> +DRI_CONF_OPT_BEGIN(clamp_max_samples, int, -1) \
> +        DRI_CONF_DESC(en,gettext("Clamp the value of GL_MAX_SAMPLES to
> the given integer. If negative, then do not clamp.")) \
> +DRI_CONF_OPT_END
>
>  /**
>   * \brief Performance-related options
> --
> 1.8.3.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131101/1f3ef711/attachment-0001.html>