[Mesa-dev] [PATCH] i965: Tell the unit states how many binding table entries we have.

Kenneth Graunke kenneth at whitecape.org
Fri Nov 1 20:20:37 PDT 2013


On 11/01/2013 07:57 PM, Eric Anholt wrote:
> Before the series with 3c9dc2d31b80fc73bffa1f40a91443a53229c8e2 to
> dynamically assign our binding table indices, we didn't really track our
> binding table count per shader, so we never filled in these fields.
> 
> Affects cairo-gl trace runtime by -2.47953% +/- 1.07281% (n=20)
> ---
>  src/mesa/drivers/dri/i965/brw_vs_state.c  | 3 ++-
>  src/mesa/drivers/dri/i965/brw_wm_state.c  | 3 ++-
>  src/mesa/drivers/dri/i965/gen6_vs_state.c | 4 +++-
>  src/mesa/drivers/dri/i965/gen6_wm_state.c | 5 +++++
>  src/mesa/drivers/dri/i965/gen7_gs_state.c | 4 +++-
>  src/mesa/drivers/dri/i965/gen7_vs_state.c | 4 +++-
>  src/mesa/drivers/dri/i965/gen7_wm_state.c | 4 ++++
>  7 files changed, 22 insertions(+), 5 deletions(-)

Nice!  I'd played with this in the past, but never measured anything.
cairo-gl is a more suitable benchmark than I was using, though.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>



More information about the mesa-dev mailing list