[Mesa-dev] [PATCH 4/5] i965/fs: Extend SEL peephole to handle only matching MOVs.

Eric Anholt eric at anholt.net
Mon Nov 4 10:34:21 PST 2013


Paul Berry <stereotype441 at gmail.com> writes:

> On 31 October 2013 18:57, Matt Turner <mattst88 at gmail.com> wrote:
>
>> Before this patch, the following code would not be optimized even though
>> the first two instructions were common to the then and else blocks:
>>
>>    (+f0) IF
>>    MOV dst0 ...
>>    MOV dst1 ...
>>    MOV dst2 ...
>>    ELSE
>>    MOV dst0 ...
>>    MOV dst1 ...
>>    MOV dst3 ...
>>    ENDIF
>>
>> This commit extends the peephole to handle this case.
>>
>> No shader-db changes.
>> ---
>> This patch made a much bigger difference when pulling instructions from the
>> ends of the "then" and "else" blocks, because often we were able to compute
>> to MRF.
>>
>
> This patch is:
>
> Reviewed-by: Paul Berry <stereotype441 at gmail.com>
>
> I'd be just as happy if you wanted to squash patches 3 and 4 together into
> a single patch.

I was going to say the same thing for my r-b.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131104/5ac91b10/attachment.pgp>


More information about the mesa-dev mailing list