[Mesa-dev] [PATCH] glsl: Don't generate misleading debug names when packing gs inputs.

Eric Anholt eric at anholt.net
Mon Nov 4 10:42:20 PST 2013

Paul Berry <stereotype441 at gmail.com> writes:

> Previously, when packing geometry shader input varyings like this:
>     in float foo[3];
>     in float bar[3];
> lower_packed_varyings would declare a packed varying like this:
>     (declare (shader_in flat) (array ivec4 3) packed:foo[0],bar[0])
> That's confusing, since the packed varying acutally stores all three
> values of foo and all three values of bar.
> This patch causes it to generate the more sensible declaration:
>     (declare (shader_in flat) (array ivec4 3) packed:foo,bar)
> Note that there should be no functional change for users of geometry
> shaders, since the packed name is only used for generating debug
> output.  But this should reduce confusion when using INTEL_DEBUG=gs.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131104/22ece239/attachment.pgp>

More information about the mesa-dev mailing list