[Mesa-dev] [PATCH 05/11] mesa: Add ARB_vertex_attrib_binding

Fredrik Höglund fredrik at kde.org
Mon Nov 4 15:35:35 PST 2013

On Monday 04 November 2013, Ian Romanick wrote:
> On 10/28/2013 03:33 PM, Fredrik Höglund wrote:
> > update_array() and update_array_format() are changed to update the new
> > attrib and binding states, and the client arrays become derived state.
> I don't think we should enable the extension until after the other
> patches.  Otherwise people can encounter spurious piglit failures while
> bisecting other problems.  I'm sure that there are some of your piglit
> tests that would fail at this point in the series... right?

Yeah, that's a good point.  I'll change the dummy_true to dummy_false
in this patch and enable it in a separate commit.  But unfortunately
I think patch 7 also needs to be squashed into patch 5 to fully avoid
such issues, since the update_array/update_format() changes also
affect the gl*Pointer() functions.


More information about the mesa-dev mailing list