[Mesa-dev] [PATCH 0/6] radeon: Plug some memory leaks
tom at stellard.net
Wed Nov 6 11:12:20 PST 2013
On Wed, Nov 06, 2013 at 12:59:09PM -0600, Aaron Watry wrote:
> On Wed, Nov 6, 2013 at 12:15 PM, Tom Stellard <tom at stellard.net> wrote:
> > These look good, but the indentation seems wrong in patches 2 through 6.
> An artifact of expanding tabs to 4 spaces in the IDE... Although I'd
> argue that patch 6 is correct given that the portion of the file
> affected already uses tabs for spaces.
> Do you want a v2, or are you happy with the patches assuming that I
> fix the indentation?
If you don't have commit access, then you will need to send a v2, so
I can commit them. If you have commit access, then these patches are
Reviewed-by: Tom Stellard <thomas.stellard at amd.com>
If you make sure the indentation is consistent.
> > -Tom
> > On Wed, Nov 06, 2013 at 10:36:49AM -0600, Aaron Watry wrote:
> >> I decided to have some fun and hooked valgrind up to my 7850 while running
> >> a few OpenCL tests in piglit. This is the first batch of fixes.
> >> Aaron Watry (6):
> >> radeon/llvm: fix spelling error
> >> radeon/llvm: Free libelf resources
> >> radeon/llvm: Free created llvm memory buffer
> >> radeonsi/compute: Free program and program.kernels on shutdown
> >> radeonsi/compute: Dispose of LLVM module after compiling kernels
> >> gallium/pipe_loader: un-reference udev resources when we're done with
> >> them.
> >> src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 3 +++
> >> src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++
> >> src/gallium/drivers/radeon/radeon_llvm_util.c | 1 +
> >> src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 +-
> >> src/gallium/drivers/radeonsi/radeonsi_compute.c | 17 ++++++++++++++++-
> >> 5 files changed, 24 insertions(+), 2 deletions(-)
> >> _______________________________________________
> >> mesa-dev mailing list
> >> mesa-dev at lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
More information about the mesa-dev