[Mesa-dev] [PATCH 0/2v2] i965: Extend fast texture upload
mattst88 at gmail.com
Thu Nov 7 13:34:34 PST 2013
On Thu, Nov 7, 2013 at 1:22 PM, Courtney Goeltzenleuchter
<courtney at lunarg.com> wrote:
> This series builds on work from Frank Henigman to optimize the
> process of uploading a texture to the GPU. This series adds support for
> MESA_XRGB_8888 and full miptrees where were found to be common activities
> in the Smokin' Guns game. The issue was found while profiling the app
> but that part is not benchmarked. Smokin-Guns uses mipmap textures with
> an internal format of GL_RGB (MESA_XRGB_8888 in the driver).
> These changes need a performance tool to run against to show how they
> improve execution performance for specific texture formats. Using this
> benchmark I've measured the following improvement on my Ivybridge
> Intel(R) Xeon(R) CPU E3-1225 V2 @ 3.20GHz.
> Using 1024x1024, RGBA 8888 source, mipmap
> internal-format Before (MB/sec) After XRGB (MB/sec) After mip (MB/sec)
> GL_RGBA 628.15 627.15 615.90
> GL_RGB 265.95 456.35 611.53
Put these results into the individual commit messages.
> Test shows similar pattern for 512x512 and 256x256.
Wouldn't hurt to include these as well.
Patch 1 (with benchmarks in the commit message) is:
Reviewed-by: Matt Turner <mattst88 at gmail.com>
I don't know anything about the miptree layout, so I don't feel able
to review the second patch, but it seems plausible.
More information about the mesa-dev