[Mesa-dev] [PATCH] glsl: fix missing breaks in equals(ir_texture, ..)

Kenneth Graunke kenneth at whitecape.org
Sat Nov 9 09:08:51 PST 2013


On 11/09/2013 01:29 AM, Chris Forbes wrote:
> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
> Cc: "10.0" <mesa-stable at lists.freedesktop.org>
> ---
>  src/glsl/opt_cse.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/glsl/opt_cse.cpp b/src/glsl/opt_cse.cpp
> index c0fdb23..c53b4c6 100644
> --- a/src/glsl/opt_cse.cpp
> +++ b/src/glsl/opt_cse.cpp
> @@ -352,6 +352,7 @@ equals(ir_texture *a, ir_texture *b)
>        if (!equals(a->lod_info.grad.dPdx, b->lod_info.grad.dPdx) ||
>            !equals(a->lod_info.grad.dPdy, b->lod_info.grad.dPdy))
>           return false;
> +      break;
>     case ir_txf_ms:
>        if (!equals(a->lod_info.sample_index, b->lod_info.sample_index))
>           return false;
> @@ -359,6 +360,7 @@ equals(ir_texture *a, ir_texture *b)
>     case ir_tg4:
>        if (!equals(a->lod_info.component, b->lod_info.component))
>           return false;
> +      break;
>     default:
>        assert(!"Unrecognized texture op");
>     }
> 

Whoops!  Good catch.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>



More information about the mesa-dev mailing list