[Mesa-dev] [PATCH 1/3] r600/llvm: initialize radeon_llvm_binary
Aaron Watry
awatry at gmail.com
Thu Nov 14 10:17:42 PST 2013
use memset to initialize to 0's... otherwise code_size and config_size
could be uninitialized when read later in this method.
It's also hard to do NULL checks on uninitialized pointers.
Reviewed-by: Tom Stellard <thomas.stellard at amd.com>
v2: Fix indentation
---
src/gallium/drivers/r600/r600_llvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c
index a2ff0ec..f6784eb 100644
--- a/src/gallium/drivers/r600/r600_llvm.c
+++ b/src/gallium/drivers/r600/r600_llvm.c
@@ -831,6 +831,7 @@ unsigned r600_llvm_compile(
const char * gpu_family = r600_llvm_gpu_string(family);
unsigned i;
+ memset(&binary, 0, sizeof(struct radeon_llvm_binary));
r = radeon_llvm_compile(mod, &binary, gpu_family, dump);
assert(binary.code_size % 4 == 0);
--
1.8.3.2
More information about the mesa-dev
mailing list