[Mesa-dev] [PATCH] i965: Add missing break in SHADER_OPCODE_GEN7_SCRATCH_READ case.

Matt Turner mattst88 at gmail.com
Fri Nov 15 00:12:27 PST 2013


On Thu, Nov 14, 2013 at 10:51 PM, Vinson Lee <vlee at freedesktop.org> wrote:
> Fixes "Missing break in switch" defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp b/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> index 39a5266..a4fae0d 100644
> --- a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
> @@ -335,6 +335,8 @@ schedule_node::set_latency_gen7(bool is_haswell)
>         * then around 140.  Presumably this is cache hit vs miss.
>         */
>        latency = 50;
> +      break;
> +
>     case SHADER_OPCODE_UNTYPED_ATOMIC:
>        /* Test code:
>         *   mov(8)    g112<1>ud       0x00000000ud       { align1 WE_all 1Q };
> --
> 1.8.4.2

Ah, man. And I reviewed that one too.

Reviewed-by: Matt Turner <mattst88 at gmail.com>

Please add the Cc 10.0 stable tag.


More information about the mesa-dev mailing list