[Mesa-dev] [PATCH 2/2] svga: print warning for unsupported indirect dest reg indexing

[Roland Scheidegger]

On 11/14/2013 09:33 PM, Brian Paul wrote:
> For DX9-level shaders, there's only limited support for indirect
> indexing of registers (with the loop counter register, not the
> general address register.)
> ---
>   src/gallium/drivers/svga/svga_tgsi_insn.c |    4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/src/gallium/drivers/svga/svga_tgsi_insn.c b/src/gallium/drivers/svga/svga_tgsi_insn.c
> index b96efbc..0fc385a 100644
> --- a/src/gallium/drivers/svga/svga_tgsi_insn.c
> +++ b/src/gallium/drivers/svga/svga_tgsi_insn.c
> @@ -107,6 +107,10 @@ translate_dst_register( struct svga_shader_emitter *emit,
>         break;
>      }
>
> +   if (reg->Register.Indirect) {
> +      debug_warning("Indirect indexing of dest registers is not supported!\n");
> +   }
> +
>      dest.mask = reg->Register.WriteMask;
>      assert(dest.mask);
>
>

Series looks good to me.

Roland