[Mesa-dev] [PATCH] glsl: Link glcpp with math library.

[Brian Paul]

On 11/20/2013 12:24 AM, Vinson Lee wrote:
> This patch fixes this build error with Oracle Solaris Studio.
>
> libtool: link: /opt/solarisstudio12.3/bin/cc -g -o glcpp/glcpp glcpp.o prog_hash_table.o  ./.libs/libglcpp.a
> Undefined			first referenced
>   symbol  			    in file
> sqrt                                prog_hash_table.o
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   src/glsl/Makefile.am |    4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am
> index cbf253c..05b6759 100644
> --- a/src/glsl/Makefile.am
> +++ b/src/glsl/Makefile.am
> @@ -93,7 +93,9 @@ libglcpp_la_SOURCES =					\
>   glcpp_glcpp_SOURCES =					\
>   	glcpp/glcpp.c					\
>   	$(top_srcdir)/src/mesa/program/prog_hash_table.c
> -glcpp_glcpp_LDADD = libglcpp.la
> +glcpp_glcpp_LDADD =					\
> +	libglcpp.la					\
> +	-lm
>
>   libglsl_la_LIBADD = libglcpp.la
>   libglsl_la_SOURCES =					\
>

This and the other two: "glapi: Do not include dlfcn.h on Windows" and 
"glsl: Use more portable bash invocation construct." look ok to me.

Reviewed-by: Brian Paul <brianp at vmware.com>