[Mesa-dev] [PATCH] mesa: initialize gl_renderbuffer::Depth in core

[Ian Romanick]

On 11/20/2013 04:27 AM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>

It seems weird that it wasn't already there.  No piglit regressions on IVB.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Tested-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>  src/mesa/drivers/dri/i915/intel_fbo.c | 2 --
>  src/mesa/drivers/dri/i965/intel_fbo.c | 2 --
>  src/mesa/main/fbobject.c              | 1 +
>  3 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i915/intel_fbo.c b/src/mesa/drivers/dri/i915/intel_fbo.c
> index f534386..36b22ca 100644
> --- a/src/mesa/drivers/dri/i915/intel_fbo.c
> +++ b/src/mesa/drivers/dri/i915/intel_fbo.c
> @@ -420,8 +420,6 @@ intel_renderbuffer_update_wrapper(struct intel_context *intel,
>     struct intel_mipmap_tree *mt = intel_image->mt;
>     int level = image->Level;
>  
> -   rb->Depth = image->Depth;
> -
>     rb->AllocStorage = intel_nop_alloc_storage;
>  
>     intel_miptree_check_level_layer(mt, level, layer);
> diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c
> index ddecb2b..642394d 100644
> --- a/src/mesa/drivers/dri/i965/intel_fbo.c
> +++ b/src/mesa/drivers/dri/i965/intel_fbo.c
> @@ -431,8 +431,6 @@ intel_renderbuffer_update_wrapper(struct brw_context *brw,
>     struct intel_mipmap_tree *mt = intel_image->mt;
>     int level = image->Level;
>  
> -   rb->Depth = image->Depth;
> -
>     rb->AllocStorage = intel_nop_alloc_storage;
>  
>     intel_miptree_check_level_layer(mt, level, layer);
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index e6a19b2..ebeed41 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -411,6 +411,7 @@ _mesa_update_texture_renderbuffer(struct gl_context *ctx,
>     rb->InternalFormat = texImage->InternalFormat;
>     rb->Width = texImage->Width2;
>     rb->Height = texImage->Height2;
> +   rb->Depth = texImage->Depth2;
>     rb->NumSamples = texImage->NumSamples;
>     rb->TexImage = texImage;
>