[Mesa-dev] [v3 0/8] Add ARB_texture_view

[Brian Paul]

On 11/19/2013 04:16 PM, Courtney Goeltzenleuchter wrote:
> The following patches add the necessary functions to Mesa
> to support ARB_texture_view. These patches do not include
> the actual driver elements, just the device independent portion.
> This extension requires ARB_texture_storage.
>
> The extension supports one new API call, glTextureView and
> a handful of enums that have been added as queriable texture
> parameters.
>
> Adds one new driver entry point for the driver to
> map the view specified onto the origtexture given.
>
> Includes review feedback and a bug fix in compatible_format.
>
> Passes non-rendering ARB_texture_view piglit tests.
>
> Courtney Goeltzenleuchter (8):
>    mesa: Add API definitions for ARB_texture_view
>    mesa: Tracking for ARB_texture_view extension
>    mesa: update texture object for ARB_texture_view
>    mesa: ARB_texture_view get parameters
>    mesa: Add driver entry point for ARB_texture_view
>    mesa: Fill out ARB_texture_view entry points
>    mesa: add texture_view helper function for TexStorage
>    mesa: Update TexStorage to support ARB_texture_view
>
>   src/mapi/glapi/gen/ARB_texture_view.xml |  23 ++
>   src/mapi/glapi/gen/Makefile.am          |   1 +
>   src/mapi/glapi/gen/gl_API.xml           |   4 +-
>   src/mapi/glapi/gen/gl_genexec.py        |   1 +
>   src/mesa/Makefile.sources               |   1 +
>   src/mesa/SConscript                     |   1 +
>   src/mesa/drivers/common/driverfuncs.c   |   3 +
>   src/mesa/main/dd.h                      |   5 +
>   src/mesa/main/extensions.c              |   1 +
>   src/mesa/main/mtypes.h                  |   6 +
>   src/mesa/main/tests/dispatch_sanity.cpp |   2 +-
>   src/mesa/main/teximage.c                |   6 +
>   src/mesa/main/texparam.c                |  60 ++-
>   src/mesa/main/texstorage.c              |   5 +-
>   src/mesa/main/textureview.c             | 684 ++++++++++++++++++++++++++++++++
>   src/mesa/main/textureview.h             |  43 ++
>   16 files changed, 838 insertions(+), 8 deletions(-)
>   create mode 100644 src/mapi/glapi/gen/ARB_texture_view.xml
>   create mode 100644 src/mesa/main/textureview.c
>   create mode 100644 src/mesa/main/textureview.h
>

For patches 1-4, 8:  Reviewed-by: Brian Paul <brianp at vmware.com>
For patches 5-7: minor comments

Nice work.

-Brian