[Mesa-dev] [v3 5/8] mesa: Add driver entry point for ARB_texture_view

[Brian Paul]

On 11/19/2013 04:16 PM, Courtney Goeltzenleuchter wrote:
>
> Signed-off-by: Courtney Goeltzenleuchter <courtney at LunarG.com>
> ---
>   src/mesa/drivers/common/driverfuncs.c | 3 +++
>   src/mesa/main/dd.h                    | 5 +++++
>   2 files changed, 8 insertions(+)
>
> diff --git a/src/mesa/drivers/common/driverfuncs.c b/src/mesa/drivers/common/driverfuncs.c
> index 5faa98a..f185688 100644
> --- a/src/mesa/drivers/common/driverfuncs.c
> +++ b/src/mesa/drivers/common/driverfuncs.c
> @@ -211,6 +211,9 @@ _mesa_init_driver_functions(struct dd_function_table *driver)
>      /* GL_ARB_texture_storage */
>      driver->AllocTextureStorage = _mesa_alloc_texture_storage;
>
> +   /* GL_ARB_texture_view */
> +   driver->TextureView = NULL;
> +
>      /* GL_ARB_texture_multisample */
>      driver->GetSamplePosition = NULL;
>   }
> diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h
> index b5b874f..3e263f4 100644
> --- a/src/mesa/main/dd.h
> +++ b/src/mesa/main/dd.h
> @@ -375,6 +375,11 @@ struct dd_function_table {
>                                       GLsizei levels, GLsizei width,
>                                       GLsizei height, GLsizei depth);
>
> +   /** Called as part of glTextureView to add views to origTexObj */
> +   GLboolean (*TextureView)(struct gl_context *ctx,
> +                            struct gl_texture_object *texObj,
> +                            struct gl_texture_object *origTexObj);

Either the comment on this function, or the place where it's called from 
should probably be beefed up with more info about what's expected of the 
driver.  Is it possible to return FALSE for any reason beyond out-of-memory?



> +
>      /**
>       * Map a renderbuffer into user space.
>       * \param mode  bitmask of GL_MAP_READ_BIT, GL_MAP_WRITE_BIT and
>