[Mesa-dev] [PATCH 2/2] glsl/linker: Validate IR just before reparenting.

Paul Berry stereotype441 at gmail.com
Fri Nov 22 13:30:10 PST 2013

If reparent_ir() is called on invalid IR, then there's a danger that
it will fail to reparent all of the necessary nodes.  For example, if
the IR contains an ir_dereference_variable which refers to an
ir_variable that's not in the tree, that ir_variable won't get
reparented, resulting in subtle use-after-free bugs once the
non-reparented nodes are freed.  (This is exactly what happened in the
bug fixed by the previous commit).

This patch makes this kind of bug far easier to track down, by
transforming it from a use-after-free bug into an explicit IR
validation error.
 src/glsl/linker.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index fac186a..1366077 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -2396,6 +2396,11 @@ done:
       if (prog->_LinkedShaders[i] == NULL)
+      /* Do a final validation step to make sure that the IR wasn't
+       * invalidated by any modifications performed after intrastage linking.
+       */
+      validate_ir_tree(prog->_LinkedShaders[i]->ir);
       /* Retain any live IR, but trash the rest. */
       reparent_ir(prog->_LinkedShaders[i]->ir, prog->_LinkedShaders[i]->ir);

More information about the mesa-dev mailing list