[Mesa-dev] [PATCH] i965: Use __attribute__((flatten)) on fast tiled teximage code.

Matt Turner mattst88 at gmail.com
Sat Nov 23 13:54:55 PST 2013

On Sat, Nov 23, 2013 at 1:41 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> The fast tiled texture upload code does not compile with GCC 4.8's -Og
> optimization flag.
> memcpy() has the always_inline attribute set.  This poses a problem,
> since {x,y}tile_copy_faster calls it indirectly via {x,y}tile_copy,
> and {x,y}tile_copy normally aren't inlined at -Og.
> Using __attribute__((flatten)) tells GCC to inline every function call
> inside the function, which I believe was the author's intent.
> Fix suggested by Alexander Monakov.
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---

Reviewed-by: Matt Turner <mattst88 at gmail.com>

More information about the mesa-dev mailing list