[Mesa-dev] [PATCH 3/9] gallium/dri2: Set winsys_handle type to KMS for stride query.

Thomas Hellstrom thellstrom at vmware.com
Sun Nov 24 23:58:37 PST 2013


On 11/25/2013 05:06 AM, Christopher James Halse Rogers wrote:
> On Thu, 2013-11-21 at 14:12 +0100, Thomas Hellstrom wrote:
>> On 11/21/2013 05:11 AM, christopher.halse.rogers at canonical.com wrote:
>>> From: Christopher James Halse Rogers <raof at ubuntu.com>
>>>
>>> Otherwise the default is TYPE_SHARED, which will flink the bo. This seems
>>> rather unnecessary for a simple stride query.
>> Is there no way we can cache this stuff in a __DRIimage? Changing the
>> calling conventions to adapt to poor implementations seems like
>> the wrong way to go. What if other drivers use a slow approach to get
>> the KMS handle?
>>
> Do you want me to add some extra gallium API to get this sort of image
> metadata without using what's essentially a side-effect of
> resource_get_handle? If this isn't a theoretical concern I can certainly
> do so

It's more of a theoretical concern. We can certainly revisit this at a 
later time.

Thanks,
Thomas


More information about the mesa-dev mailing list