[Mesa-dev] [PATCH 3/3] gallium/cso: fix sampler / sampler_view counts

Roland Scheidegger sroland at vmware.com
Tue Nov 26 06:44:15 PST 2013

Am 26.11.2013 06:24, schrieb Zack Rusin:
> The entire series looks good to me.
>> Now that it is possible to query drivers for the max sampler view it should
>> be safe to increase this without crashing.
>> Not entirely convinced this really works correctly though if state trackers
>> using non-linked sampler / sampler_views use this.
> I'm not sure if I get this. What would be the problem in that case?

It looked to me like the code isn't really prepared for this, though
actually I guess it would be more of a problem with not updating all
views or samplers from 0 to count rather than different number of views
/ samplers. (The code stores the "count" paramater as nr_views etc. and
will then save/restore views based on nr_views starting at zero).
In any case this change shouldn't make it worse.


More information about the mesa-dev mailing list