[Mesa-dev] [PATCH] Fixed memory leak.

[Alex Deucher]

On Tue, Nov 26, 2013 at 1:22 PM, Siavash Eliasi <siavashserver at gmail.com> wrote:

In general, when you fix problems in prior patches, you should
integrate the fix into the original patch(es) where the problems were,
update the commit message to note what bugs were fixed and then
re-send the patch set.  That prevents broken commits from getting into
the git tree even if they are fixed in a later commit. You can use git
rebase -i to integrate your fixes.

Alex

> ---
>  src/mesa/main/bufferobj.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
> index 5581a5d..e68d96d 100644
> --- a/src/mesa/main/bufferobj.c
> +++ b/src/mesa/main/bufferobj.c
> @@ -420,6 +420,8 @@ _mesa_buffer_data( struct gl_context *ctx, GLenum target, GLsizeiptrARB size,
>
>     new_data = _mesa_align_malloc( size, ctx->Const.MinMapBufferAlignment );
>     if (new_data) {
> +      _mesa_align_free( bufObj->Data );
> +
>        bufObj->Data = (GLubyte *) new_data;
>        bufObj->Size = size;
>        bufObj->Usage = usage;
> --
> 1.8.4.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev