[Mesa-dev] Enable ARB_map_buffer_alignment in all drivers - first try

[Ian Romanick]

On 11/26/2013 07:42 PM, Timothy Arceri wrote:
> Hi Thomas,
> 
> Looks like Siavash Eliasi beat you to it.
> 
> But here is some quick feedback. You seem to have made the same mistake
> with your case statements [1]
> Also you shouldn't attach the patch to your email but should use
> git-send-email there is a link to more info on the Newbie page ;)

I did a quick skim, and it looks like most of the Thomas's and Siavash's
changes are similar.  Another way Thomas could help is by reviewing
Siavash's patches... places where they're the same can get a trivial
Reviewed-by.  Places where they're different should incite some disucssion.

> As for the remaining Newbie tasks it looks like work has been started on
> those [2] but the ARB_clear_buffer_object work hasn't been tested so you
> could have a go at writing the piglit tests this would give you a good
> understanding on the spec and what the extension is meant to do from
> there you might be able to fix up any issues with the patch. 
> 
> [1]http://lists.freedesktop.org/archives/mesa-dev/2013-November/049054.html
> [2]http://lists.freedesktop.org/archives/mesa-dev/2013-November/048944.html
> 
> On Tue, 2013-11-26 at 19:48 +0000, Thomas Prescher wrote:
>> Hi,
>>
>> today I read an article on phoronix
>> (http://www.phoronix.com/scan.php?page=news_item&px=MTUyNDY) which
>> linked to a wiki page (http://wiki.freedesktop.org/dri/NewbieProjects/)
>> where easy projects to start with were listed. I gave it a shot and
>> tried to implement the ARB_map_buffer_alignment extensions for all
>> drivers. Long story short, here is the patch I've created. I'm not
>> completely sure whether everything I did was what the creator of the
>> wiki page had in mind. I am especially unsure about the last item. Ofc
>> it would be very great iff one of you  guys can provide some feedback :)
>>
>> -Thomas
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>