[Mesa-dev] [PATCH 2/4] glsl: Fix inconsistent assumptions about ir_loop::counter.

Kenneth Graunke kenneth at whitecape.org
Thu Nov 28 12:00:59 PST 2013


On 11/27/2013 12:44 PM, Paul Berry wrote:
> The compiler back-ends (i965's fs_visitor and brw_visitor,
> ir_to_mesa_visitor, and glsl_to_tgsi_visitor) assume that when
> ir_loop::counter is non-null, it points to a fresh ir_variable that
> should be used as the loop counter (as opposed to an ir_variable that
> exists elsewhere in the instruction stream).
> 
> However, previous to this patch:

...Wow.  That's more awful than I thought.  Thanks for bringing some
sanity to this code.

This series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list