[Mesa-dev] [PATCH 01/10] radeon: move some functions to r600_buffer.c
Christoph Brill
egore911 at egore911.de
Fri Nov 29 10:24:20 PST 2013
Reviewed-by: Christoph Brill <egore911 at gmail.com>
2013/11/29 Marek Olšák <maraeo at gmail.com>
> From: Marek Olšák <marek.olsak at amd.com>
>
> ---
> src/gallium/drivers/radeon/Makefile.sources | 1 +
> src/gallium/drivers/radeon/r600_buffer.c | 133
> ++++++++++++++++++++++++++
> src/gallium/drivers/radeon/r600_pipe_common.c | 106 --------------------
> 3 files changed, 134 insertions(+), 106 deletions(-)
> create mode 100644 src/gallium/drivers/radeon/r600_buffer.c
>
> diff --git a/src/gallium/drivers/radeon/Makefile.sources
> b/src/gallium/drivers/radeon/Makefile.sources
> index 894f22a..bd06ed8 100644
> --- a/src/gallium/drivers/radeon/Makefile.sources
> +++ b/src/gallium/drivers/radeon/Makefile.sources
> @@ -1,4 +1,5 @@
> C_SOURCES := \
> + r600_buffer.c \
> r600_pipe_common.c \
> r600_streamout.c \
> r600_texture.c \
> diff --git a/src/gallium/drivers/radeon/r600_buffer.c
> b/src/gallium/drivers/radeon/r600_buffer.c
> new file mode 100644
> index 0000000..13d11bd
> --- /dev/null
> +++ b/src/gallium/drivers/radeon/r600_buffer.c
> @@ -0,0 +1,133 @@
> +/*
> + * Copyright 2013 Advanced Micro Devices, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the
> "Software"),
> + * to deal in the Software without restriction, including without
> limitation
> + * on the rights to use, copy, modify, merge, publish, distribute, sub
> + * license, and/or sell copies of the Software, and to permit persons to
> whom
> + * the Software is furnished to do so, subject to the following
> conditions:
> + *
> + * The above copyright notice and this permission notice (including the
> next
> + * paragraph) shall be included in all copies or substantial portions of
> the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT
> SHALL
> + * THE AUTHOR(S) AND/OR THEIR SUPPLIERS BE LIABLE FOR ANY CLAIM,
> + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
> + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR
> THE
> + * USE OR OTHER DEALINGS IN THE SOFTWARE.
> + *
> + * Authors:
> + * Marek Olšák
> + */
> +
> +#include "r600_cs.h"
> +
> +void *r600_buffer_map_sync_with_rings(struct r600_common_context *ctx,
> + struct r600_resource *resource,
> + unsigned usage)
> +{
> + enum radeon_bo_usage rusage = RADEON_USAGE_READWRITE;
> +
> + if (usage & PIPE_TRANSFER_UNSYNCHRONIZED) {
> + return ctx->ws->buffer_map(resource->cs_buf, NULL, usage);
> + }
> +
> + if (!(usage & PIPE_TRANSFER_WRITE)) {
> + /* have to wait for the last write */
> + rusage = RADEON_USAGE_WRITE;
> + }
> +
> + if (ctx->rings.gfx.cs->cdw &&
> + ctx->ws->cs_is_buffer_referenced(ctx->rings.gfx.cs,
> + resource->cs_buf, rusage)) {
> + if (usage & PIPE_TRANSFER_DONTBLOCK) {
> + ctx->rings.gfx.flush(ctx, RADEON_FLUSH_ASYNC);
> + return NULL;
> + } else {
> + ctx->rings.gfx.flush(ctx, 0);
> + }
> + }
> + if (ctx->rings.dma.cs &&
> + ctx->rings.dma.cs->cdw &&
> + ctx->ws->cs_is_buffer_referenced(ctx->rings.dma.cs,
> + resource->cs_buf, rusage)) {
> + if (usage & PIPE_TRANSFER_DONTBLOCK) {
> + ctx->rings.dma.flush(ctx, RADEON_FLUSH_ASYNC);
> + return NULL;
> + } else {
> + ctx->rings.dma.flush(ctx, 0);
> + }
> + }
> +
> + if (ctx->ws->buffer_is_busy(resource->buf, rusage)) {
> + if (usage & PIPE_TRANSFER_DONTBLOCK) {
> + return NULL;
> + } else {
> + /* We will be wait for the GPU. Wait for any
> offloaded
> + * CS flush to complete to avoid busy-waiting in
> the winsys. */
> + ctx->ws->cs_sync_flush(ctx->rings.gfx.cs);
> + if (ctx->rings.dma.cs)
> + ctx->ws->cs_sync_flush(ctx->rings.dma.cs);
> + }
> + }
> +
> + return ctx->ws->buffer_map(resource->cs_buf, NULL, usage);
> +}
> +
> +bool r600_init_resource(struct r600_common_screen *rscreen,
> + struct r600_resource *res,
> + unsigned size, unsigned alignment,
> + bool use_reusable_pool, unsigned usage)
> +{
> + uint32_t initial_domain, domains;
> +
> + switch(usage) {
> + case PIPE_USAGE_STAGING:
> + /* Staging resources participate in transfers, i.e. are
> used
> + * for uploads and downloads from regular resources.
> + * We generate them internally for some transfers.
> + */
> + initial_domain = RADEON_DOMAIN_GTT;
> + domains = RADEON_DOMAIN_GTT;
> + break;
> + case PIPE_USAGE_DYNAMIC:
> + case PIPE_USAGE_STREAM:
> + /* Default to GTT, but allow the memory manager to move it
> to VRAM. */
> + initial_domain = RADEON_DOMAIN_GTT;
> + domains = RADEON_DOMAIN_GTT | RADEON_DOMAIN_VRAM;
> + break;
> + case PIPE_USAGE_DEFAULT:
> + case PIPE_USAGE_STATIC:
> + case PIPE_USAGE_IMMUTABLE:
> + default:
> + /* Don't list GTT here, because the memory manager would
> put some
> + * resources to GTT no matter what the initial domain is.
> + * Not listing GTT in the domains improves performance a
> lot. */
> + initial_domain = RADEON_DOMAIN_VRAM;
> + domains = RADEON_DOMAIN_VRAM;
> + break;
> + }
> +
> + res->buf = rscreen->ws->buffer_create(rscreen->ws, size, alignment,
> + use_reusable_pool,
> + initial_domain);
> + if (!res->buf) {
> + return false;
> + }
> +
> + res->cs_buf = rscreen->ws->buffer_get_cs_handle(res->buf);
> + res->domains = domains;
> + util_range_set_empty(&res->valid_buffer_range);
> +
> + if (rscreen->debug_flags & DBG_VM && res->b.b.target ==
> PIPE_BUFFER) {
> + fprintf(stderr, "VM start=0x%llX end=0x%llX | Buffer %u
> bytes\n",
> + r600_resource_va(&rscreen->b, &res->b.b),
> + r600_resource_va(&rscreen->b, &res->b.b) +
> res->buf->size,
> + res->buf->size);
> + }
> + return true;
> +}
> diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c
> b/src/gallium/drivers/radeon/r600_pipe_common.c
> index 5674f81..2cdca77 100644
> --- a/src/gallium/drivers/radeon/r600_pipe_common.c
> +++ b/src/gallium/drivers/radeon/r600_pipe_common.c
> @@ -319,109 +319,3 @@ boolean r600_rings_is_buffer_referenced(struct
> r600_common_context *ctx,
> }
> return FALSE;
> }
> -
> -void *r600_buffer_map_sync_with_rings(struct r600_common_context *ctx,
> - struct r600_resource *resource,
> - unsigned usage)
> -{
> - enum radeon_bo_usage rusage = RADEON_USAGE_READWRITE;
> -
> - if (usage & PIPE_TRANSFER_UNSYNCHRONIZED) {
> - return ctx->ws->buffer_map(resource->cs_buf, NULL, usage);
> - }
> -
> - if (!(usage & PIPE_TRANSFER_WRITE)) {
> - /* have to wait for the last write */
> - rusage = RADEON_USAGE_WRITE;
> - }
> -
> - if (ctx->rings.gfx.cs->cdw &&
> - ctx->ws->cs_is_buffer_referenced(ctx->rings.gfx.cs,
> - resource->cs_buf, rusage)) {
> - if (usage & PIPE_TRANSFER_DONTBLOCK) {
> - ctx->rings.gfx.flush(ctx, RADEON_FLUSH_ASYNC);
> - return NULL;
> - } else {
> - ctx->rings.gfx.flush(ctx, 0);
> - }
> - }
> - if (ctx->rings.dma.cs &&
> - ctx->rings.dma.cs->cdw &&
> - ctx->ws->cs_is_buffer_referenced(ctx->rings.dma.cs,
> - resource->cs_buf, rusage)) {
> - if (usage & PIPE_TRANSFER_DONTBLOCK) {
> - ctx->rings.dma.flush(ctx, RADEON_FLUSH_ASYNC);
> - return NULL;
> - } else {
> - ctx->rings.dma.flush(ctx, 0);
> - }
> - }
> -
> - if (ctx->ws->buffer_is_busy(resource->buf, rusage)) {
> - if (usage & PIPE_TRANSFER_DONTBLOCK) {
> - return NULL;
> - } else {
> - /* We will be wait for the GPU. Wait for any
> offloaded
> - * CS flush to complete to avoid busy-waiting in
> the winsys. */
> - ctx->ws->cs_sync_flush(ctx->rings.gfx.cs);
> - if (ctx->rings.dma.cs)
> - ctx->ws->cs_sync_flush(ctx->rings.dma.cs);
> - }
> - }
> -
> - return ctx->ws->buffer_map(resource->cs_buf, NULL, usage);
> -}
> -
> -bool r600_init_resource(struct r600_common_screen *rscreen,
> - struct r600_resource *res,
> - unsigned size, unsigned alignment,
> - bool use_reusable_pool, unsigned usage)
> -{
> - uint32_t initial_domain, domains;
> -
> - switch(usage) {
> - case PIPE_USAGE_STAGING:
> - /* Staging resources participate in transfers, i.e. are
> used
> - * for uploads and downloads from regular resources.
> - * We generate them internally for some transfers.
> - */
> - initial_domain = RADEON_DOMAIN_GTT;
> - domains = RADEON_DOMAIN_GTT;
> - break;
> - case PIPE_USAGE_DYNAMIC:
> - case PIPE_USAGE_STREAM:
> - /* Default to GTT, but allow the memory manager to move it
> to VRAM. */
> - initial_domain = RADEON_DOMAIN_GTT;
> - domains = RADEON_DOMAIN_GTT | RADEON_DOMAIN_VRAM;
> - break;
> - case PIPE_USAGE_DEFAULT:
> - case PIPE_USAGE_STATIC:
> - case PIPE_USAGE_IMMUTABLE:
> - default:
> - /* Don't list GTT here, because the memory manager would
> put some
> - * resources to GTT no matter what the initial domain is.
> - * Not listing GTT in the domains improves performance a
> lot. */
> - initial_domain = RADEON_DOMAIN_VRAM;
> - domains = RADEON_DOMAIN_VRAM;
> - break;
> - }
> -
> - res->buf = rscreen->ws->buffer_create(rscreen->ws, size, alignment,
> - use_reusable_pool,
> - initial_domain);
> - if (!res->buf) {
> - return false;
> - }
> -
> - res->cs_buf = rscreen->ws->buffer_get_cs_handle(res->buf);
> - res->domains = domains;
> - util_range_set_empty(&res->valid_buffer_range);
> -
> - if (rscreen->debug_flags & DBG_VM && res->b.b.target ==
> PIPE_BUFFER) {
> - fprintf(stderr, "VM start=0x%llX end=0x%llX | Buffer %u
> bytes\n",
> - r600_resource_va(&rscreen->b, &res->b.b),
> - r600_resource_va(&rscreen->b, &res->b.b) +
> res->buf->size,
> - res->buf->size);
> - }
> - return true;
> -}
> --
> 1.8.3.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131129/13b34834/attachment-0001.html>
More information about the mesa-dev
mailing list