[Mesa-dev] [PATCH] glsl: Fix usage of the wrong union member in program_resource_visitor::recursion.

Kenneth Graunke kenneth at whitecape.org
Fri Oct 4 12:25:32 PDT 2013


On 10/04/2013 10:03 AM, Ian Romanick wrote:
> On 09/20/2013 07:28 PM, Francisco Jerez wrote:
>> In the array-of-struct case, recursion() takes the row_major flag for
>> each iteration from 't->fields.structure[i]', but 't' is not a record
>> type.  Inherit the array declaration row_major flag instead.
>>
>> This mistake was found by running piglit on valgrind.
> 
> Yeah, this looks like a dumb copy-and-paste mistake.
> 
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: "9.1 9.2" <mesa-stable at lists.freedesktop.org>

It fixes the bug I filed about this, too.  Thanks!

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69449
Tested-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list