[Mesa-dev] [PATCH] i965: extend fast texture upload
fjhenigman at google.com
Mon Oct 7 18:19:52 PDT 2013
On Wed, Sep 25, 2013 at 1:18 PM, Chad Versace
<chad.versace at linux.intel.com> wrote:
v2 sent to mesa-dev.
While incorporating your suggestions, I couldn't resist some
additional rewording of comments.
I trust you'll find them for the better.
> Me and Paul Berry verified no Piglit regressions on an Ivybridge with
> swizzling disabled.
> Did you verify the swizzling case on Sandybridge or Ivybridge?
Yes, and thanks for your testing.
> The name tile_copy_fn makes sense, because it's used to copy one tile at
> a time. Analogously, I expected pixel_copy_fn to be used to copy one
> pixel at a time. But it isn't... it's used to copy one *span* at
> a time. The mismatch between these two functions names confused me.
> Please rename pixel_copy_fn to better reflect its use by matching the parity
> tile_copy_fn. I like span_copy_fn, if you think that's appropriate.
I chose mem_copy_fn. span_copy_fn suggests it copies a span, but it
is also used for less than a full span.
More information about the mesa-dev