[Mesa-dev] [PATCH 2/3] mesa: Fix compiler warnings when ALIGN's alignment is "1 << value".

Eric Anholt eric at anholt.net
Tue Oct 8 10:36:09 PDT 2013


We hadn't run into order of operation warnings before, apparently, since
addition is so low on the order.

Cc: "9.1 9.2" <mesa-stable at lists.freedesktop.org>
---
 src/mesa/main/macros.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/macros.h b/src/mesa/main/macros.h
index 1052f75..05aad4e 100644
--- a/src/mesa/main/macros.h
+++ b/src/mesa/main/macros.h
@@ -673,7 +673,7 @@ minify(unsigned value, unsigned levels)
  *
  * \sa ROUND_DOWN_TO()
  */
-#define ALIGN(value, alignment)  (((value) + alignment - 1) & ~(alignment - 1))
+#define ALIGN(value, alignment)  (((value) + (alignment) - 1) & ~((alignment) - 1))
 
 
 
-- 
1.8.4.rc3



More information about the mesa-dev mailing list