[Mesa-dev] [PATCH] R600/SI: fix MIMG writemask adjustement

Michel Dänzer michel at daenzer.net
Wed Oct 9 18:33:29 CEST 2013


On Mit, 2013-10-09 at 16:39 +0200, Marek Olšák wrote:
> No, I just added the test.

Which means you didn't address Tom's LLVM coding style comment,
requiring C++ formatting (// instead of /**/) for the comment below:


> >>   +    /* Lane means which subreg of %VGPRa_VGPRb_VGPRc_VGPRd is used.
> >> +     * Note that subregs are packed, i.e. Lane==0 is the first bit set
> >> +     * in OldDmask, so it can be any of X,Y,Z,W; Lane==1 is the second
> >> bit
> >> +     * set, etc. */



-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer



More information about the mesa-dev mailing list