[Mesa-dev] [PATCH 2/2] i965: Use IVB specific formula for depthbuffer

[Brian Paul]

On 10/09/2013 05:13 PM, Chad Versace wrote:
> On 10/09/2013 03:14 PM, Ian Romanick wrote:
>> On 10/09/2013 02:49 PM, Chad Versace wrote:
>>> On 10/08/2013 04:27 PM, Ben Widawsky wrote:
>>>> +      }
>>>> +      hz_height /= 2;
>>>> +      break;
>>>> +   default:
>>>> +      perf_debug("Unknown depthbuffer texture type (%d).",
>>>> mt->target);
>>>
>>> I thought I commented on the perf_debug() before, but maybe I forgot to
>>> send that draft.
>>>
>>> perf_debug() should be used only for known issues that affect
>>> performance. The issue
>>> here is much more dire: if we hit the default case, then we have hit a
>>> real bug, because
>>> we forgot to write code to handle all the targets.
>>>
>>> Instead, use fprintf(stderr, ...). Also, always print GLenum values as
>>> "0x%x".
>>
>> You mean _mesa_problem, right? :)
>
> In most of the miptree code, there is no ctx, so I avoided _mesa_problem().
> But you're right. In the hiz allocation functio, we do have a ctx.

IIRC, _mesa_warning() and _mesa_warning() don't actually use the ctx 
parameter so it can be NULL.

-Brian