[Mesa-dev] [PATCH] llvmpipe: We don't use the draw pipeline for offset_point/line.

Brian Paul brianp at vmware.com
Thu Oct 10 23:35:25 CEST 2013


On 10/09/2013 06:01 PM, jfonseca at vmware.com wrote:
> From: José Fonseca <jfonseca at vmware.com>
>
> Unless the polygon fill mode is different PIPE_POLYGON_MODE_FILL, so
> checking the the polygon mode is sufficient.
>
> Testing done: no regression in polygon-mode-offset
> ---
>   src/gallium/drivers/llvmpipe/lp_state_rasterizer.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/gallium/drivers/llvmpipe/lp_state_rasterizer.c b/src/gallium/drivers/llvmpipe/lp_state_rasterizer.c
> index 6148337..2149ffc 100644
> --- a/src/gallium/drivers/llvmpipe/lp_state_rasterizer.c
> +++ b/src/gallium/drivers/llvmpipe/lp_state_rasterizer.c
> @@ -78,8 +78,6 @@ llvmpipe_create_rasterizer_state(struct pipe_context *pipe,
>       */
>      need_pipeline = (rast->fill_front != PIPE_POLYGON_MODE_FILL ||
>   		    rast->fill_back != PIPE_POLYGON_MODE_FILL ||
> -                    rast->offset_point ||
> -                    rast->offset_line ||
>   		    rast->point_smooth ||
>   		    rast->line_smooth ||
>   		    rast->line_stipple_enable ||
>

I don't remember all the circumstances of when I made that change 
originally, but if it seems to fix things, great.

Tag for 9.2 branch?

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list