[Mesa-dev] [PATCH 0/3] translate, rtasm fixes for 64-bit Cygwin
brianp at vmware.com
Fri Oct 11 02:08:22 CEST 2013
On 10/10/2013 08:01 AM, Jon TURNEY wrote:
> Since 64-bit Cygwin is now a thing, fix translate_sse for it.
> (It's unclear that it's ever worked on the Windows 64-bit target. Commit c2da8e77023325f46dde2009def2947b1a687c7b
> "translate_sse: major rewrite (v5)" adds untested support for 64-bit Windows, and then commit
> f4dd0991719ef3e2606920c5100b372181c60899 disabled tranlate_sse.c on MinGW x86_64 because of crashes.)
> Jon TURNEY (3):
> rtasm: The heap is NX on 64-bit Cygwin, so use the rtasm_exec_malloc()
> implementation which uses mmap()
> rtasm: Cygwin uses the msabi calling convention on x86_64
> traslate_sse: Fix generated code argument handling for msabi on x86_64
> src/gallium/auxiliary/rtasm/rtasm_execmem.c | 2 +-
> src/gallium/auxiliary/rtasm/rtasm_x86sse.h | 2 +-
> src/gallium/auxiliary/translate/translate_sse.c | 14 +++++++++++---
> 3 files changed, 13 insertions(+), 5 deletions(-)
Looks OK to me, AFAICT.
I could probably do some testing on mingw64 one of these days...
Reviewed-by: Brian Paul <brianp at vmware.com>
Wow, the formatting in translate/*.c is a mess. I'm tempted to run
indent on it someday.
More information about the mesa-dev