[Mesa-dev] [PATCH] glcpp: error on multiple #else directives

Erik Faye-Lund kusmabite at gmail.com
Fri Oct 11 14:21:01 CEST 2013


On Mon, Sep 23, 2013 at 11:02 PM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
> On Mon, Sep 23, 2013 at 10:35 PM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
>> The preprocessor currently eats multiple #else directives
>> int the same #if(def) ... #endif block. While I haven't been able
>> to find anything that explicitly disallows it, it's nonsensical
>> and should probably not be allowed.
>>
>> Add checks to reject the code.
>> ---
>>
>> I'm not entirely sure why parser->skip_stack can be NULL after
>> _glcpp_parser_skip_stack_change_if, but apparently it is for at
>> least one test.
>>
>> I'm also not entirely sure if this should be an error or a warning.
>> Thoughts?
>>

Ping? Any thoughts?


More information about the mesa-dev mailing list