[Mesa-dev] [PATCH] configure: set HAVE_COMMON_DRI when building plain classic swrast

[Matt Turner]

On Fri, Oct 11, 2013 at 9:19 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Commit d81632fb1(dri: Merge drisw_util.c into dri_util.c) unified the
> dri and drisw util code, but forgot to set HAVE_COMMON_DRI. Thus the
> translations for driconf (that drisw now depends on) were not built,
> leading to a build errors.
>
> This is the equivalent for classic dri drivers of commit 757ec72b2
> (configure: set HAVE_COMMON_DRI when building only swrast).
>
> Cc: Eric Anholt <eric at anholt.net>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70378
> Reported-by: Fabio Pedretti <fabio.ped at libero.it>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---

As far as I recall, the purpose of HAVE_COMMON_DRI was to build the
common DRI code only when needed (i.e., needed for DRI drivers, not
needed for swrast). The problem according to ffc8494db is that someone
wants the ability to build classic swrast without xf86drm.h.

I think now that xf86drm.h's include is protected by __NOT_HAVE_DRM_H
we can now just drop HAVE_COMMON_DRI entirely. Right?