[Mesa-dev] [PATCH] i965: add XRGB to fast texture upload

[Ian Romanick]

On 10/11/2013 10:16 AM, Courtney Goeltzenleuchter wrote:
> MESA_FORMAT_XRGB8888 is equivalent to MESA_FORMAT_ARGB8888 in terms
> of storage on the device, so okay to use this optimized copy routine.
> ---
>  src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965/intel_tex_subimage.c
> index 5cfdbd9..4aec05d 100644
> --- a/src/mesa/drivers/dri/i965/intel_tex_subimage.c
> +++ b/src/mesa/drivers/dri/i965/intel_tex_subimage.c
> @@ -564,7 +564,8 @@ intel_texsubimage_tiled_memcpy(struct gl_context * ctx,
>         (texImage->TexFormat == MESA_FORMAT_A8 && format == GL_ALPHA)) {
>        cpp = 1;
>        mem_copy = memcpy;
> -   } else if (texImage->TexFormat == MESA_FORMAT_ARGB8888) {
> +   } else if ((texImage->TexFormat == MESA_FORMAT_ARGB8888) ||
> +	      (texImage->TexFormat == MESA_FORMAT_XRGB8888)) {
>        cpp = 4;
>        if (format == GL_BGRA) {
>           mem_copy = memcpy;
> 

Are there appropriate test cases that hit this path?  I don't think
piglit exercises a lot of different texture formats.  I just want to be
sure that some test now hits this fast path that didn't hit it before.