[Mesa-dev] [PATCH 7/7] i965: Move the common binding table offset code to brw_shader.cpp.

Eric Anholt eric at anholt.net
Tue Oct 15 10:19:17 PDT 2013

Paul Berry <stereotype441 at gmail.com> writes:

> On 4 October 2013 15:44, Eric Anholt <eric at anholt.net> wrote:
>> Now that both vec4 and fs are dynamically assigning offsets, a lot of the
>> code is the same.
>> ---
> Since next_binding_table_offset is only used to into
> assign_common_binding_table_offsets(), I'd prefer to see it made into a
> function argument rather than a class member.  That way it wouldn't be
> necessary to grep through the code to verify that no one else uses it.
> With that changed, this patch is:
> Reviewed-by: Paul Berry <stereotype441 at gmail.com>

Thanks.  I agree that's cleaner, too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131015/b0e981bf/attachment.pgp>

More information about the mesa-dev mailing list