[Mesa-dev] [PATCH 4/7] i965/fs: Add reads_reg() and writes_flag() to fs_inst.

Ian Romanick idr at freedesktop.org
Tue Oct 22 22:30:04 CEST 2013


On 10/22/2013 01:07 PM, Matt Turner wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 16 ++++++++++++++++
>  src/mesa/drivers/dri/i965/brw_fs.h   |  3 +++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index 77b898b..9b56764 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -730,6 +730,22 @@ fs_inst::regs_read(fs_visitor *v, int arg)
>     return 1;
>  }
>  
> +bool
> +fs_inst::reads_flag()
> +{
> +   if (predicate)
> +      return true;
> +   return false;

This seems a bit more obvious:

    return predicate != 0;

> +}
> +
> +bool
> +fs_inst::writes_flag()
> +{
> +   if (conditional_mod)
> +      return true;
> +   return false;

Ditto.

> +}
> +
>  /**
>   * Returns how many MRFs an FS opcode will write over.
>   *
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h
> index 3104717..f241095 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.h
> +++ b/src/mesa/drivers/dri/i965/brw_fs.h
> @@ -149,6 +149,9 @@ public:
>     bool is_partial_write();
>     int regs_read(fs_visitor *v, int arg);
>  
> +   bool reads_flag();
> +   bool writes_flag();
> +
>     fs_reg dst;
>     fs_reg src[3];
>     bool saturate;
> 



More information about the mesa-dev mailing list