[Mesa-dev] [PATCH] r600g/sb: fix value::is_fixed()

Vadim Girlin vadimgirlin at gmail.com
Sun Oct 27 13:55:29 CET 2013


---
cc: Andreas Boll <andreas.boll.dev at gmail.com>

Andreas, this patch should fix the issue with SB on RV770 that you 
reported on IRC (assert with interpolation-mixed.shader_test).

There are no piglit regressions with this patch on my evergreen,
but I can't test with r700 or any other chips.

 src/gallium/drivers/r600/sb/sb_valtable.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/r600/sb/sb_valtable.cpp b/src/gallium/drivers/r600/sb/sb_valtable.cpp
index 00aee66..0d39e9c 100644
--- a/src/gallium/drivers/r600/sb/sb_valtable.cpp
+++ b/src/gallium/drivers/r600/sb/sb_valtable.cpp
@@ -255,8 +255,8 @@ void value::set_prealloc() {
 bool value::is_fixed() {
 	if (array && array->gpr)
 		return true;
-	if (chunk)
-		return chunk->is_fixed();
+	if (chunk && chunk->is_fixed())
+		return true;
 	return flags & VLF_FIXED;
 }
 
-- 
1.8.3.1



More information about the mesa-dev mailing list