[Mesa-dev] [PATCH 5/5] i965: Enable the ARB_transform_feedback_instanced extension on Gen7+.

Ian Romanick idr at freedesktop.org
Mon Oct 28 18:57:35 CET 2013


On 10/26/2013 01:33 PM, Kenneth Graunke wrote:
> This depends on ARB_transform_feedback2, so I've predicated it on the
> ability to do register writes.
> 
> It also depends on ARB_transform_feedback3, which is the only reason we
> couldn't expose it previously.

Dare I even ask if we have tests?

> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Assuming we have tests,

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>  src/mesa/drivers/dri/i965/intel_extensions.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c
> index e08d93a..03d20a4 100644
> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> @@ -228,8 +228,10 @@ intelInitExtensions(struct gl_context *ctx)
>     if (brw->gen >= 7) {
>        ctx->Extensions.ARB_texture_gather = true;
>        ctx->Extensions.ARB_conservative_depth = true;
> -      if (can_do_pipelined_register_writes(brw))
> +      if (can_do_pipelined_register_writes(brw)) {
>           ctx->Extensions.ARB_transform_feedback2 = true;
> +         ctx->Extensions.ARB_transform_feedback_instanced = true;
> +      }
>        ctx->Extensions.ARB_transform_feedback3 = true;
>     }
>  
> 



More information about the mesa-dev mailing list