[Mesa-dev] [PATCH] radeonsi: Allow longer intrinsic names

[Tom Stellard]

On Tue, Oct 29, 2013 at 08:34:16PM +0100, Kai Wasserb??ch wrote:
> Tom Stellard schrieb am 29.10.2013 17:48:
> > On Sun, Oct 27, 2013 at 07:36:07PM +0100, Kai Wasserb??ch wrote:
> >> Fixes a boat load of Piglit tests for me, which crashed like fdo#70913
> >> before.
> >>
> >> Thanks to Michel D??nzer for the tip.
> >>
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70913
> >> Signed-off-by: Kai Wasserb??ch <kai at dev.carbon-project.org>
> > 
> > This looks OK to me, which intrinsic names were too long?
> 
> In this particular instance (see the backtrace
> <https://bugs.freedesktop.org/attachment.cgi?id=88177> (#11)) and all other
> similar crashes I saw "llvm.SI.imageload.v4i3".
> 
> > Reviewed-by: Tom Stellard <thomas.stellard at amd.com>
> 
> Thanks for the review! As I don't have commit access, you ??? or someone else with
> the appropriate rights ??? would need to commit this fix on my behalf. Thanks in
> advance for that!
> 

I have pushed this patch, thanks!

-Tom

> >> ---
> >>  src/gallium/drivers/radeonsi/radeonsi_shader.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c
> >> index 9f81a7b..dff8be0 100644
> >> --- a/src/gallium/drivers/radeonsi/radeonsi_shader.c
> >> +++ b/src/gallium/drivers/radeonsi/radeonsi_shader.c
> >> @@ -1425,7 +1425,7 @@ static void build_tex_intrinsic(const struct lp_build_tgsi_action * action,
> >>  				struct lp_build_emit_data * emit_data)
> >>  {
> >>  	struct lp_build_context * base = &bld_base->base;
> >> -	char intr_name[23];
> >> +	char intr_name[127];
> >>  
> >>  	sprintf(intr_name, "%sv%ui32", action->intr_name,
> >>  		LLVMGetVectorSize(LLVMTypeOf(emit_data->args[0])));
> >> -- 
> >> 1.8.4.rc3
>