[Mesa-dev] [PATCH 6/6] mesa: fix NUM_COMPRESSED_TEXTURE_FORMATS query

[Ian Romanick]

On 10/31/2013 10:45 AM, Ian Romanick wrote:
> On 10/31/2013 10:21 AM, Marek Olšák wrote:
>> On Thu, Oct 31, 2013 at 6:19 PM, Ian Romanick <idr at freedesktop.org> wrote:
>>> On 10/31/2013 08:42 AM, Marek Olšák wrote:
>>>> From: Marek Olšák <marek.olsak at amd.com>
>>>>
>>>> Cc: mesa-stable at lists.freedesktop.org
>>>
>>> This is not correct.  GL_COMPRESSED_TEXTURE_FORMATS is only supposed to
>>> return texture formats "suitable for general-purpose usage."  Since
>>> GL_COMPRESSED_RGBA_S3TC_DXT1_EXT only has 1 bit for alpha, it's not
>>> suitable for general-purpose usage.  As far as I'm aware, nobody else
>>> returns that format either... and I think we have a piglit test.
>>
>> Yes, we have a piglit test which expects 4 formats, not 3.
> 
> tests/spec/arb_texture_compression/invalid-formats.c expects that
> GL_COMPRESSED_RGBA_S3TC_DXT1_EXT is not included in
> GL_COMPRESSED_TEXTURE_FORMATS.
> 
> It looks like tests/spec/gl-3.1/minmax.c expects
> GL_NUM_COMPRESSED_TEXTURE_FORMATS be at least 4, but I have no idea what
> it's expecting GL_COMPRESSED_TEXTURE_FORMATS will be.  There are no
> general-purpose compression formats part of the spec (only RGTC
> formats), so... I think that's also a spec bug, and I've submitted a
> Khronos bug for that too.  Ugh. :(

Okay... there already was a bug, and it was fixed in OpenGL 4.2.  We
should change those minmax tests to only expect 0 for
GL_NUM_COMPRESSED_TEXTURE_FORMATS.

>> Marek
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev