[Mesa-dev] [PATCH 1/3] draw: cleanup the extra attribs

[Stéphane Marchesin]

On Tue, Sep 3, 2013 at 9:38 PM, Matt Turner <mattst88 at gmail.com> wrote:

> On Tue, Sep 3, 2013 at 8:20 PM, Stéphane Marchesin
> <stephane.marchesin at gmail.com> wrote:
> > Hi Zack,
> >
> > This change regresses a bunch of point sprite piglit tests on i915g.
> Should
> > we revert back to the old behaviour? As far as I can see, it was correct
> (it
> > was keeping the attributes in case another stage is using them).
> >
> > Stéphane
>
> This commit actually already lead to three regression reports:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=67963
> https://bugs.freedesktop.org/show_bug.cgi?id=67965
> https://bugs.freedesktop.org/show_bug.cgi?id=67966
>
>
Okay, then I think we should revert to the older behavior, as my impression
from looking at the code is that it was doing the correct thing before.
I'll send a patch.



> In fact, Zack has 11 regression reports filed (from Aug 3-10) against
> commits he made, including one commit titled "softpipe: fix the
> regressions" that oddly enough caused two regressions.
>
>
Hmm, I'm not tracking the softpipe driver piglit state (although "someone"
should :). Maybe I should start to do that.

Stéphane
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130904/f447688a/attachment-0001.html>