[Mesa-dev] [PATCH] Revert "draw: cleanup the extra attribs"

Zack Rusin zackr at vmware.com
Wed Sep 4 13:06:32 PDT 2013


> This reverts commit 57cd3267782fcf92d1e7d772760956516d4367df.
> 
> This fixes piglit regressions with additional draw stages on
> llvmpipe, softpipe and i915g. The attributes can't be cleared at
> this point because they might be in use by the additional draw
> stages.

The attributes have to cleared but the interface for looking them up has to be exactly the same in llvmpipe (i.e. only llvmpipe does it correctly).

> https://bugs.freedesktop.org/show_bug.cgi?id=67963
> https://bugs.freedesktop.org/show_bug.cgi?id=67965
> https://bugs.freedesktop.org/show_bug.cgi?id=67966

All of which have been fixed for a long time, just no one had the time to verify and close. In other words please don't revert, if you don't feel like changing the shader output lookup just remove the prepare_shader_outputs call, like I mentioned, and that should get you the old behavior back.

z


More information about the mesa-dev mailing list