[Mesa-dev] [PATCH 18/21] glsl: Write a new built-in function module.

Kenneth Graunke kenneth at whitecape.org
Wed Sep 4 16:53:13 PDT 2013


On 09/04/2013 04:36 PM, Erik Faye-Lund wrote:
> On Thu, Sep 5, 2013 at 12:22 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> +#define B0(X) ir_function_signature *_##X();
>> +#define B1(X) ir_function_signature *_##X(const glsl_type *);
>> +#define B2(X) ir_function_signature *_##X(const glsl_type *, const glsl_type *);
>> +#define B3(X) ir_function_signature *_##X(const glsl_type *, const glsl_type *, const glsl_type *);
>> +   B1(radians)
>> +   B1(degrees)
>> +   B1(sin)
>> +   B1(cos)
> <snip>
>> +   B1(bitCount)
>> +   B1(findLSB)
>> +   B1(findMSB)
>> +   B1(fma)
>> +#undef B
>
> Shouldn't this be:
> #undef B0
> #undef B1
> #undef B2
> #undef B3
>
> ?

Yes, it should...thanks for catching that.  I've fixed this, and also 
added #undefs for the other FIU* macros as well.

--Ken


More information about the mesa-dev mailing list